Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude not enumerable keys of inject object #6346

Merged
merged 7 commits into from
Sep 13, 2017
Merged

Conversation

Elevista
Copy link
Contributor

@Elevista Elevista commented Aug 11, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

image
In resolveInject function
If inject parameter object has 'not enumerable' properties, shows error below
image

Because
image

result of Object.keys(inject) is not equal to Reflect.ownKeys(inject) even without symbol

Hanks10100 and others added 2 commits July 24, 2017 07:32
* build(release weex): ignore the file path of entries

* [release] weex-vue-framework@2.4.2-weex.1
@pdanpdan
Copy link
Contributor

This should be automatically fixed by #6322, as it always recreate the inject object.
But it would be nice if you could add a test for your case.

@Elevista
Copy link
Contributor Author

test case added

@yyx990803 yyx990803 merged commit 3ee62fd into vuejs:dev Sep 13, 2017
ztlevi pushed a commit to ztlevi/vue that referenced this pull request Feb 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants