New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v-model binding with array. (fix #3958,#3979) #3988

Merged

yyx990803 merged 5 commits into vuejs:dev from defcc:model-binding-fix

Oct 22, 2016

Member

defcc commented Oct 20, 2016 •

edited

fix #3958 #3979
As for array type case, v-model="model[idx]" binding uses model[idx]= internally, so the value change could not be reactive.

the binding model expression maybe be as follows:

test
test[idx]
test[test1[idx]]
xxx.test[a[a].test1[idx]]
test.xxx.a["asa"][test1[idx]]
test["a"][idx]

So I use a modelParser to parse the model expression to two parts exp and idx, and if the exp is an Array type, then use $$exp.splice($$idx, 1, value)

defcc added 5 commits

October 20, 2016 01:05


          fix v-model with array binding

471dcd4


          add mutli selects test case

1e13395


          add test case. v-bind with array

c8ad6ae


          add comments

ede799a


          code refactor

5b5c86c

yyx990803 added the in review label

yyx990803 merged commit 3105661 into vuejs:dev

Member

yyx990803 commented Oct 22, 2016

Beautifully done! 💯

sqal mentioned this pull request

GeoJSON Object #4081

Closed

blade254353074 commented Nov 15, 2016 •

edited

@defcc @yyx990803

What about test[index].key?
test: [{ key: 'value' }]

https://jsbin.com/medatifajo/1/edit?html,js,output

Member Author

defcc commented Nov 16, 2016

already fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment