fix: Prevent spread operator from disabling the rule (#2456)

vuejs · May 9, 2024 · 98e030a · 98e030a
1 parent f0aa5dc
commit 98e030a
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -3133,7 +3133,7 @@ function getWithDefaultsProps(node) {
 
   for (const prop of param.properties) {
     if (prop.type !== 'Property') {
-      return {}
+      continue
     }
     const name = getStaticPropertyName(prop)
     if (name != null) {

diff --git a/tests/lib/rules/require-default-prop.js b/tests/lib/rules/require-default-prop.js
@@ -329,6 +329,28 @@ ruleTester.run('require-default-prop', rule, {
         ...languageOptions,
         parserOptions: { parser: require.resolve('@typescript-eslint/parser') }
       }
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      const defaultProps = {
+        foo: 'foo',
+      }
+      withDefaults(defineProps<{
+        foo: string;
+        bar?: number;
+      }>(), {
+        ...defaultProps,
+        bar: 42,
+      })
+      </script>
+      `,
+      languageOptions: {
+        parser: require('vue-eslint-parser'),
+        ...languageOptions,
+        parserOptions: { parser: require.resolve('@typescript-eslint/parser') }
+      }
     }
   ],
 
@@ -544,6 +566,33 @@ ruleTester.run('require-default-prop', rule, {
         ...languageOptions
       }
     },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup lang="ts">
+      const defaultProps = {
+        foo: 'foo',
+      }
+      withDefaults(defineProps<{
+        foo: string;
+        bar?: number;
+      }>(), {
+        ...defaultProps,
+      })
+      </script>
+      `,
+      errors: [
+        {
+          message: "Prop 'bar' requires default value to be set.",
+          line: 8
+        }
+      ],
+      languageOptions: {
+        parser: require('vue-eslint-parser'),
+        ...languageOptions,
+        parserOptions: { parser: require.resolve('@typescript-eslint/parser') }
+      }
+    },
     ...(semver.lt(
       require('@typescript-eslint/parser/package.json').version,
       '4.0.0'