Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / prohibit the use of old ABTester versions #12

Merged
merged 9 commits into from May 5, 2021

Conversation

valentino-amadeus
Copy link
Contributor

What is the purpose of this pull request?

To prevent the user from using old versions of the ABTester.

What problem is this solving?

Some old versions of vtex.ab-tester haven't been working properly.
Also, this change will simplify the cli's code.

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@valentino-amadeus
Copy link
Contributor Author

This last test keeps timing out :kaotico:

@valentino-amadeus
Copy link
Contributor Author

Seems to be common :harold-pain: yarnpkg/yarn#8242

@valentino-amadeus
Copy link
Contributor Author

Just tried again, and it worked! 🎉 :watt:

@gris
Copy link
Contributor

gris commented May 5, 2021

Please lint your project and commit again

Copy link
Contributor

@gris gris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the disclaimer that I didn't test the plugin nor have enough context about the removals on promptSignificanceLevel

@valentino-amadeus
Copy link
Contributor Author

promptSignificanceLevel has only been used with old versions of vtex.ab-tester. It will not be possible to use these old versions anymore.

@valentino-amadeus valentino-amadeus merged commit 9251b2c into master May 5, 2021
@valentino-amadeus valentino-amadeus deleted the abtester_version branch May 5, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants