Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow displaying color name in sku #993

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NAVODYA123
Copy link

What problem is this solving?

This PR is added to facilitate to allow an option to display the name of the color for a color specification instead of the image. A prop named showNameOfColor was added. When a boolean input of true is passed to this prop, the sku selector will show the color name as a label in a clickable button. This allows to have flexibility to choose between a text value representation of the color specification or an image representation. The default value of this prop is set to false

How to test it?

Workspace

Screenshots or example usage:

Before
before

After
after

@NAVODYA123 NAVODYA123 requested review from a team as code owners November 15, 2021 13:22
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 15, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@NAVODYA123
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant