feat/sku-variation-color-props #978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
moran-dev
requested review from
mullerjk,
igorbrasileiro,
victorhmp and
camilavcoutinho
|
Beep boop 馃 Thank you so much for keeping our documentation up-to-date 鉂わ笍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The context of the change was basically because SKU Color Variation always display a button with a image inside and don't have a props to change that behavior. In this project, we had this particular design for Color variation. So, I made it possible to control this particular variation with a boolean value.
How to test it?
1- Open the Workspace.
2- Use ReactDevTools to change props between true or false. (https://prnt.sc/1t4qy5u)
Workspace
Screenshots or example usage:
Before ( Normal SKU-Selector as Store-Theme)
After:
isImage: trueisImage: falseHow does this PR make you feel? 馃敆