Feature/product images slider per group prop #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 馃 Thank you so much for keeping our documentation up-to-date 鉂わ笍 |
jsjoaorsouza
requested review from
mullerjk,
RodrigoTadeuF,
pillarluz and
dvm1984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
This solution add the possibility of change the number of the thumbnail slides skipped when the thumbnail arrow is clicked.
How to test it?
Click on the link below to see the implementation. The value of the slides skipped are set by the block property "slidesPerGroup". If the prop isnt used, the default value of 4 slides is set. The block documentation was updated with the description of the property added.
https://avtjoao2--avantivtexio.myvtex.com/jogo-de-banho-padrao-fantastique-03-02-0072-p41525-copy42/p
Screenshots or example usage:
The value of the slides skipped used in the workspace was 1
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 馃敆
![](put .gif link here - can be found under "advanced" on giphy)