Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature displayMode select for Color Variation #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mihaidanieldumitru
Copy link

What problem is this solving?

This feature is needed in order to render color variations inside shelves using a dropdown. Before the only way was a slider/list of buttons.

How to test it?

Workspace

Screenshots or example usage:

  "product-summary-sku-selector#shelf": {
    "props": {
      "maxItems": 50,
      "displayMode": "select",
      "showVariationsLabels": "none",
      "initialSelection": "empty",
      "visibility": "more-than-one",
      "visibleVariations": ["Culoare"],
+    "displayModeSelectForColorVariation": true,
      "blockClass": "defaultShelf"
    }
  },

image

Copy link
Contributor

vtex-io-ci-cd bot commented Feb 27, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@mihaidanieldumitru mihaidanieldumitru force-pushed the feature/display-mode-select-for-color-variation branch from 645f421 to 659f596 Compare March 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant