Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance TBT improvement rendering videos only it's selected #1103

Merged
merged 3 commits into from Mar 6, 2024

Conversation

arturmagalhaesjr
Copy link
Contributor

What problem is this solving?

TBT when there are videos from Youtube or Vimeo.

Solution:

Only the target video is selected, and then it's rendered.

How to test it?

https://www.raamdecoratievantuiss.nl/cavendish-warme-steen-vouwgordijn-20258/p?workspace=labprod3

Copy link
Contributor

vtex-io-ci-cd bot commented Feb 22, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@icazevedo icazevedo merged commit 8c83aa9 into master Mar 6, 2024
4 of 6 checks passed
@icazevedo icazevedo deleted the fix/video-carousel-tbt branch March 6, 2024 19:04
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 6, 2024

Your PR has been merged! App is being published. 🚀
Version 3.172.1 → 3.172.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-components@3.172.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants