Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sortVariationsByLabel when all labels are numeric #1102

Merged
merged 9 commits into from Feb 13, 2024

Conversation

wender
Copy link
Contributor

@wender wender commented Feb 13, 2024

What problem is this solving?

  • When sortVariationsByLabel is true, check if the labels are all numbers and sort them as numbers instead of string

How to test it?

Workspace

Screenshots or example usage:

Before the change:
image

After the change:
image

Copy link
Contributor

vtex-io-ci-cd bot commented Feb 13, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link
Contributor

@arturmagalhaesjr arturmagalhaesjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wender wender merged commit 4d1d2e7 into master Feb 13, 2024
4 of 5 checks passed
@wender wender deleted the bugfix/sort-variations-all-numbers branch February 13, 2024 19:34
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 13, 2024

Your PR has been merged! App is being published. 🚀
Version 3.172.0 → 3.172.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-components@3.172.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants