Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat added unavailable class name #1101

Merged
merged 7 commits into from Feb 9, 2024
Merged

Conversation

jorgeAcostaVTEX
Copy link
Contributor

@jorgeAcostaVTEX jorgeAcostaVTEX commented Jan 31, 2024

What problem is this solving?

PDP Sku selector shows unavailable items crossed out. Some clients require to hide these items via CSS with a CSS HANDLE

How to test it?

Go to the workspace and use css to hide class unavailable

Workspace

Screenshots or example usage:

image

image

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link
Contributor

vtex-io-ci-cd bot commented Jan 31, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 31, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@wender wender merged commit 7db1881 into master Feb 9, 2024
4 of 5 checks passed
@wender wender deleted the featAddedUnavailableClassName branch February 9, 2024 17:42
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 9, 2024

Your PR has been merged! App is being published. 🚀
Version 3.171.0 → 3.172.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-components@3.172.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants