Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapseHeight prop at ProductDescription #1097

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tiago-freire
Copy link

@tiago-freire tiago-freire commented Oct 27, 2023

What problem is this solving?

Currently the height of 220px is explicitly defined in the code. This PR creates a collapseHeight prop at ProductDescription that defines the content minimum height in pixels when collapseContent prop is true (default: 220 for compatibility with current version).

How to test it?

"product-description": {
  "props": {
    "collapseHeight": 117
  }
}

Workspace

Screenshots or example usage:

Before:
before

After:
after

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 27, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@tiago-freire
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant