Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acessibility): added ARIA-label property to resolve accessibilit… #1096

Merged
merged 4 commits into from Jan 9, 2024

Conversation

joaocongio
Copy link
Contributor

@joaocongio joaocongio commented Oct 9, 2023

What problem is this solving?

Adicionado a propriedade aria-label para melhorar experiência de leitores de tela e resolver ajustes de acessibilidade apontados pelo Lighthouse.

How to test it?

Workspace

Screenshots or example usage:

Antes da alteração:
Search Before

Depois da alteração (o ajuste não foi mais apontado pelo Lighthouse):
Search After

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 9, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 9, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@joaocongio
Copy link
Contributor Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@joaocongio
Copy link
Contributor Author

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opa João, muito obrigado pelas melhorias!

Deixei alguns comentários que precisam ser vistos antes de prosseguir. Dá uma lida e qualquer estarei aqui pra tirar dúvidas.

react/components/SearchBar/AutocompleteInput.tsx Outdated Show resolved Hide resolved
react/components/SearchBar/AutocompleteInput.tsx Outdated Show resolved Hide resolved
@lariciamota lariciamota merged commit da64a32 into vtex-apps:master Jan 9, 2024
3 of 5 checks passed
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 9, 2024

Your PR has been merged! App is being published. 🚀
Version 3.170.0 → 3.171.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-components@3.171.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants