Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: openShareDialogClick on click is true except when it is emailShareButton #1094

Merged
merged 2 commits into from Oct 5, 2023

Conversation

caroolcanelas
Copy link

What problem is this solving?

The modal on the email share button is not being opened when clicked.

Ref: https://www.npmjs.com/package/react-share

OpenShareDialogOnClick (boolean): Open dialog on click. Defaults to true except on EmailShareButton

How to test it?

before
image
Click on the email option and nothing happens

after
image
Click on the email option and the expected modal opens

Related to / Depends on

Zendesk: #879384

How does this PR make you feel? 🔗

@caroolcanelas caroolcanelas added bug Something isn't working good first issue Good for newcomers labels Aug 29, 2023
@caroolcanelas caroolcanelas self-assigned this Aug 29, 2023
@caroolcanelas caroolcanelas requested a review from a team as a code owner August 29, 2023 19:03
@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Aug 29, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT

@caroolcanelas caroolcanelas requested review from filipewl and removed request for icazevedo August 29, 2023 19:15
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 29, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@iago1501 iago1501 merged commit c5e947c into master Oct 5, 2023
6 checks passed
@iago1501 iago1501 deleted the fix/socialShare-email branch October 5, 2023 18:55
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 5, 2023

Your PR has been merged! App is being published. 🚀
Version 3.169.3 → 3.169.4

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-components@3.169.4

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants