fixed some smaller german translation issues #1091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 馃 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
improved to fixed
... learning by doing
mmhmm... changelog rules. one gotta learn to understand the hard ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Found the horrible german Translations for "save" (Speichern instead of Sparen). Changed that to a more clear version (using Discount / Rabatt), on the way, i also fixed some not so nice sounding ways of expressing.
How to test it?
Link the component on a german website. Have a discount. See translations making sense
(https://kaibrockelt--ibksport.myvtex.com/fahrrad?__bindingAddress=www.ibksport.de/)
Screenshots or example usage:
Describe alternatives you've considered, if any.
I could have used the literal Translation "sparen", but nobody really uses that.
Related to / Depends on
Nothing, except for YOU :*
How does this PR make you feel? 馃敆