[Sku selector] - Fix sku slider rendering the parent shelf #1078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The
"displayMode": "slider"
prop of the sku-selector component does not behave correctly when used inside a shelf with slider, duplicating the same shelf inside the sku selector component.This problem is caused because the slider component uses the
list-context
to display the slides, and being inside another slider generates context conflicts.To resolve this I imported the
ListContextProvider
and placed theSliderLayout
inside it passing the proplist={[]}
to the provider in theVariation
component ofSKUSelector
.How to test it?
Screenshots or example usage:
Before (the shelf is rendered inside the sku selector component on click on the slider's arrows) :
After (the slide behaves correctly):
Example usage:
How does this PR make you feel? 🔗