Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include all html attributes to image #1076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EduardoRodriguesF
Copy link

What problem is this solving?

Recently I made a PR spreading all remaining props of an image. Here I am simply documenting it.

Related to / Depends on

Depends on vtex-apps/store-image#77

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 27, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@camilavcoutinho camilavcoutinho removed the request for review from clara-cruz April 14, 2023 15:00
Copy link

@georgebrindeiro georgebrindeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for this other PR to be approved to merge:

vtex-apps/store-image#77

@EduardoRodriguesF
Copy link
Author

@georgebrindeiro is there any status on when the other PR could be reviewed? It's been a couple of weeks and I'm afraid my contribution could get forgotten in there.

This issue is very important for us to build stores with better SEO, and we'd like to avoid forking the app for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants