Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img protocol #1070

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Img protocol #1070

wants to merge 44 commits into from

Conversation

LeslieJRP
Copy link

What problem is this solving?

Use the image protocol to display personalized images (using InfoCard)

How to test it?

To test this we need to have all three apps (store-components, image-protocol, and image-protocol-example) linked to our workspace and have saved URLs for a specific customer class and image id.
[https://imageprotocol--lreyes.myvtex.com/](Link to workspace)

Screenshots or example usage:

Desktop infocard

Mobile infocard

Describe alternatives you've considered, if any.

Related to / Depends on

This change depends on the image-protocol and image-protocol-example apps

How does this PR make you feel? 馃敆

![https://media.giphy.com/media/26u4lOMA8JKSnL9Uk/giphy.gif]

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 5, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

@vtex-io-docs-bot
Copy link

Beep boop 馃

Thank you so much for keeping our documentation up-to-date 鉂わ笍

@github-actions
Copy link

github-actions bot commented May 9, 2023

Fails
馃毇

Please remove the line ## [3.163.3] - 2022-11-17 from CHANGELOG.md
This will be automatically added once this PR is merged.

Warnings
鈿狅笍

Changes were made to package.json, but not to yarn.lock - Perhaps you need to run yarn install?

Generated by 馃毇 dangerJS against 06a94a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants