Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'colours' to possibleValues #1043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simmbiote
Copy link

For our project we needed to change "colour" to "colours" for a number of reasons. This has caused the colour sku selector to stop working. Ideally we do not want to create a custom component just for this reason.

What problem is this solving?

The colour Sku selector is no longer showing the thumbnailImage on our sites after needing to change the attribute from "colour" to "colours"
image

How to test it?

[Workspace](Link goes here!)

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 馃敆

![](put .gif link here - can be found under "advanced" on giphy)

For our project we needed to change "colour" to "colours" for a number of reasons. This has caused the sku selector to stop working. Ideally we do not want to create a custom component just for this reason.
@simmbiote simmbiote requested a review from a team as a code owner July 14, 2022 07:56
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 14, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 14, 2022

Beep boop 馃

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 馃
  • I'll do it later 馃槥

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 馃帀馃帀

@simmbiote
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

@simmbiote
Copy link
Author

Beep boop 馃

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 馃
  • I'll do it later 馃槥

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 馃帀馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant