Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new CSS handle to handle the impossible items #1009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VitorTheGreat
Copy link

What problem is this solving?

When we use the "hideImpossibleCombinations" props as false, to show all sku variants, we don't have a specific class to deal with that, so I am adding a simple CSS handle to have a class to deal with this options

How to test it?

Workspace

Screenshots or example usage:

Screenshot from 2022-02-01 21-32-23
Screenshot from 2022-02-01 21-32-29

Describe alternatives you've considered, if any.

None

Related to / Depends on

None

How does this PR make you feel? 馃敆

Awesome!

![](put .gif link here - can be found under "advanced" on giphy)

@VitorTheGreat VitorTheGreat requested a review from a team as a code owner February 2, 2022 00:33
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 2, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

@vtex-io-docs-bot
Copy link

Beep boop 馃

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 馃
  • I'll do it later 馃槥

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 馃帀馃帀

@VitorTheGreat
Copy link
Author

Beep boop robot

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document thinking
  • I'll do it later disappointed

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated tadatada

@VitorTheGreat
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! robot

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually disappointed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant