Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add productClusterHighlights handler #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devthalys
Copy link

What problem is this solving?

This new condition option allows developers to create conditions for display product flags. If a developer wanted to create a display conditional on product cluster highlights he could use this subject

How to test it?

Create a condition layout like the following:

 "condition-layout.product#cond1": {
    "props": {
      "conditions": [
        {
          "subject": "productClusterHighlights",
          "arguments": {
            "id": "1802"
          }
        }
      ],
      "Then": "rich-text#flag",
      "Else": "rich-text#no-flag"
    }
  },

  "rich-text#flag": {
    "props": {
      "text": "flag"
    }
  },

  "rich-text#no-flag": {
    "props": {
      "text": "no flag"
    }
  },

@devthalys devthalys requested review from a team as code owners June 8, 2023 03:31
@devthalys devthalys requested review from Isabella-Veloso and removed request for a team June 8, 2023 03:31
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jun 8, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@devthalys devthalys requested review from hellofanny, danzanzini and eduardoformiga and removed request for a team June 8, 2023 03:31
@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@danzanzini
Copy link

Hey @Thalys001. Can you provide a workspace with the setting being used? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants