Feature/salesChannel

[germanBonacchi]

What problem is this solving?

Change condition-layout.binding to be able to have the salesChannel as subject

How to test it?

Link and store-theme with a vtex.condition-layout@2.x:condition-layout.binding block with condition like this "conditions": [ { "subject": "salesChannel", "arguments": { "id": "2" } } ],
Workspace

Screenshots or example usage:

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[vtex-io-docs-bot]

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

[sheilagomes]

@germanBonacchi , when you need translation/reviews please open a JIRA task for the Product Localization team. I opened one for this PR, but here are the instructions for opening one next time.

[germanBonacchi]

@sheilagomes i can't access to the links that you share, i am not from vtex anymore

[sheilagomes]

@sheilagomes i can't access to the links that you share, i am not from vtex anymore

Oh, ok, no problem! The task is open and the final delivery date is October 21. When it's done, I'll push the corrections to the PR.

[germanBonacchi]

@sheilagomes I can´t use the VTEX IO CI/CD Bot to select a versions, but it needs to be a minor

[sheilagomes]

@germanBonacchi , we need to clarify the term Sales Channel used in this app, as sometimes this term is used as equivalent to Trade Policy in other apps. What do you mean exactly by sales channel here? Can you give an example of a sales channel, just for us to be sure on the translation?

[germanBonacchi]

Hi @sheilagomes , yes is a confused term sometimes.

I'm talking about Sales Channel equivalent to Trade Policy.

For example we have 4 createad here: https://beautycounterqa.myvtex.com/admin/Site/Store.aspx

And if the user is in the sc=1 we want to show some content and if sc=2 show other.

[sheilagomes]

Suggested change

	"admin/editor.condition-layout-binding.condition": "Condition Binding block",
	"admin/editor.condition-layout-binding.conditions": "Conditions Binding",
	"admin/editor.condition-layout-binding.subject.bindingId": "Selected bindingId",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Selected Sales Channel"
	"admin/editor.condition-layout-binding.condition": "Binding conditions block",
	"admin/editor.condition-layout-binding.conditions": "Binding conditions",
	"admin/editor.condition-layout-binding.subject.bindingId": "Selected binding ID",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Selected trade policy"

[sheilagomes]

Suggested change

	"admin/editor.condition-layout-binding.condition": "Condition Binding block",
	"admin/editor.condition-layout-binding.conditions": "Conditions Binding",
	"admin/editor.condition-layout-binding.subject.bindingId": "Selected bindingId",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Selected Sales Channel"
	"admin/editor.condition-layout-binding.condition": "Binding conditions block",
	"admin/editor.condition-layout-binding.conditions": "Binding conditions",
	"admin/editor.condition-layout-binding.subject.bindingId": "Selected binding ID",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Selected trade policy"

[sheilagomes]

Suggested change

	"admin/editor.condition-layout-binding.condition": "Bloque de condición Binding",
	"admin/editor.condition-layout-binding.conditions": "Condiciones Binding",
	"admin/editor.condition-layout-binding.subject.bindingId": "BindingId seleccionado",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Sales Channel seleccionado"
	"admin/editor.condition-layout-binding.condition": "Bloque de condiciones de vínculo",
	"admin/editor.condition-layout-binding.conditions": "Condiciones de vínculo",
	"admin/editor.condition-layout-binding.subject.bindingId": "ID del vínculo seleccionado",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Política comercial seleccionada"

[sheilagomes]

Suggested change

	"admin/editor.condition-layout-binding.condition": "Bloco de condições Binding",
	"admin/editor.condition-layout-binding.conditions": "Condições Binding",
	"admin/editor.condition-layout-binding.subject.bindingId": "BindingId selecionado",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Sales Channel selecionado"
	"admin/editor.condition-layout-binding.condition": "Bloco de condições de vínculo",
	"admin/editor.condition-layout-binding.conditions": "Condições de vínculo",
	"admin/editor.condition-layout-binding.subject.bindingId": "ID do vínculo selecionado",
	"admin/editor.condition-layout-binding.subject.salesChannel": "Política comercial selecionada"