Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasMoreSKUsThan condition #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cristian-milea
Copy link
Contributor

@cristian-milea cristian-milea commented Nov 5, 2021

What problem is this solving?

This change adds a new condition to product page, hasMoreSKUsThan

How to test it?

Workspace

Example usage:

"condition-layout.product#multiple": {
    "props": {
      "conditions": [
        {
          "subject": "hasMoreSKUsThan",
          "arguments": {
            "quantity": 3
          }
        }
      ],
      "Then": "rich-text#meaning-of-life",
      "Else": "rich-text#is-always-42"
    }
  },

How does this PR make you feel? 馃敆

@cristian-milea cristian-milea requested review from a team as code owners November 5, 2021 00:00
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 5, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

@cristian-milea cristian-milea requested review from icazevedo, victorhmp, pillarluz and brunoamui and removed request for a team November 5, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant