Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Quectel BG95 (SSL/TLS/HTTPS/GPS/GNSS) #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aurelihein
Copy link

@aurelihein aurelihein commented Sep 23, 2023

This commit add support for Quectel BG95 (SSL/TLS/HTTPS/GPS/GNSS)
I have also updated the library version number
Let me know if you need any modification
Thank you
Aurelien BOUIN

Note : Tested on ESP32S3 + BG95-M3

#elif defined(TINY_GSM_MODEM_SECURE_BG95)
#include "TinyGsmClientSecureBG95.h"
typedef TinyGsmBG95 TinyGsm;
typedef TinyGsmBG95::GsmClientSecureBG95 TinyGsmClientSecure;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for BG96 but why are you adding references to BG95?

@@ -110,6 +111,7 @@ Watch this repo for new updates! And of course, contributions are welcome ;)
- ESP8266 - 5
- Neoway M590 - 2
- Quectel BG96 - 12
- Quectel BG95 - 12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BG95 or BG96?

@@ -158,7 +160,7 @@ Watch this repo for new updates! And of course, contributions are welcome ;)

**Location**
- GPS/GNSS
- SIM808, SIM7000, SIM7500/7600/7800, BG96, u-blox
- SIM808, SIM7000, SIM7500/7600/7800, BG96, BG95, u-blox

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same Question

@aurelihein aurelihein changed the title Add support for Quectel BG96 (SSL/TLS/HTTPS/GPS/GNSS) Add support for Quectel BG95 (SSL/TLS/HTTPS/GPS/GNSS) Jan 8, 2024
@aurelihein
Copy link
Author

I just updated the PR title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants