Avoid unnecessary timeout when receiving "SEND FAIL" response from SIM7000 modem #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for "SEND FAIL" response from SIM7000 modem
Gelemikke
changed the title
Gelemikke
changed the title
Allows checking if the change baud rate command was correctly received by the modem and helps avoiding mismatch in baud rate
The function implementation is more or less a copy from the SIM7000 function as the same command is supported by both modems
add getNetworkSystemMode() for SIM7600
Make setBaud() return a bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for "SEND FAIL" response from SIM7000 modem
Without this change the transmission pauses for 1 second when "SEND FAIL" is received from the modem as the code ends up in the unhandled case in waitResponse() after the default 1 second timeout. This significantly reduces the possible throughput.