Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cardinal points in location by gps for sim7600 #738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Juxn3
Copy link

@Juxn3 Juxn3 commented Jul 25, 2023

In the sim7600 modem, when the location is being obtained recurrently from the second iteration, it does not process the cardinal points correctly.
Fix cardinal points in location by gps for modem sim7600

#566

#641

@imorda
Copy link

imorda commented Jul 28, 2023

You might want to check the #736. There is a trouble in gps parser so it expects some extra delimeters not compliant with the protocol, that might be the actual reason for the inconsistency you experience here

jorisvervuurt added a commit to jorisvervuurt/TinyGSM_SIM7600 that referenced this pull request Feb 9, 2024
@jorisvervuurt
Copy link

You might want to check the #736. There is a trouble in gps parser so it expects some extra delimeters not compliant with the protocol, that might be the actual reason for the inconsistency you experience here

I have just confirmed that this in fact is not related to #736. stream.read() somehow does not return the actual character. The solution to use stream.readStringUntil(',').charAt(0) does fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants