Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @SRGDamia1 @vshymanskyy thank you for your great work.
This PR fixes two issues with the NTPServerSync function.
Prior to this PR, you could not set negative timezones because the passed value was byte (which translates to uin8_t). Now the value passed it's an Int so you can set any timezone (from -47 to +48).
On old SIM800 the return code of +CNTP was always:
+CNTP: <code>
but now with newer modules you could also get the network time attached to the response like this:+CNTP: <code>[,<time>]
. What I did to keep backward compatibility is to look for the ',' and remove all the leading characters if found. If not, assume the reply was just the<code>
.It is working perfectly on my SIM7000.
Thanks
Gonzalo