New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated vscode file icons with stable and insider versions (1.35) #2092
Updated vscode file icons with stable and insider versions (1.35) #2092
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
======================================
Coverage 100% 100%
======================================
Files 78 78
Lines 5959 5959
Branches 138 138
======================================
Hits 5959 5959 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
======================================
Coverage 100% 100%
======================================
Files 78 78
Lines 5959 5959
Branches 138 138
======================================
Hits 5959 5959
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not replace. Add new.
So just append another number for the new versions like 3 & 4 or what? I don't get the idea. |
Just like a list. New gets added on top. Old gets pushed one place down the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. @KingDarBoja are you still waiting for the folder backgrounds color to be changed or should we merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vscode second one should not be replaced by insiders icon
@robertohuertasm Don't merge until I resolve the icons. I'm out of town and it's difficult for me to coordinate this by phone. |
@robertohuertasm Let's wait for the folder background to be fixed by JimiC. And of course, I would fix the Cheers! |
I properly updated the |
4212efb
to
1d6e2e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @KingDarBoja! 🚀
Fixes #2087
Changes proposed:
Since the new
vscode
icon is the same for all platforms (check this response), I replaced thevscode2
icon with the insiders version just in case someone wants to use it.Also, this PR is not ready yet because I have to change the folder icon too.
I would like to ask if I could change the
vs
icon too for the new one.UPDATE: Gonna need some help with the folder color for the
vscode
andvscode2
@JimiC .