Skip to content

Commit

Permalink
Merge pull request #77 from mwcraig/fix-qt-error
Browse files Browse the repository at this point in the history
Fix logic in check for python version
  • Loading branch information
mwcraig committed Feb 17, 2020
2 parents e6b5105 + a7b4ed4 commit f37880b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .gitignore
Expand Up @@ -28,6 +28,9 @@ var/

!vpython/lib

# Notebook stuff
.ipynb_checkpoints

# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
Expand Down
3 changes: 3 additions & 0 deletions Demos_no_notebook/qt.py
@@ -0,0 +1,3 @@
from vpython import *
set_browser(type='pyqt')
b = box()
2 changes: 1 addition & 1 deletion vpython/no_notebook.py
Expand Up @@ -249,7 +249,7 @@ def onClose(self, wasClean, code, reason):
raise RuntimeError('The pyqt browser cannot be used on Windows. '
'Please use the default browser instead by '
'removing set_browser("pyqt") from your code.')
elif sys.version_info.major == 3 and sys.version_info.minor >= 7:
elif sys.version_info.major == 3 and sys.version_info.minor >= 8:
raise RuntimeError('The pyqt browser cannot be used on Python 3.8. '
'Please use the default browser instead by '
'removing set_browser("pyqt") from your code.')
Expand Down

0 comments on commit f37880b

Please sign in to comment.