Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to C++17 #537

Merged
merged 3 commits into from
Mar 19, 2024
Merged

switch to C++17 #537

merged 3 commits into from
Mar 19, 2024

Conversation

MichaelRawson
Copy link
Contributor

It's been about three years since we switched to C++14 in #197. C++17 has things we would like, so let's switch.

This:

  1. Switches the compiler flags appropriately.
  2. Fixes resulting warnings (std::result_of deprecated in favour of std::invoke_result)
  3. Goes through the code fixing all "when we have C++17" comments - except for one in Hash.hpp @joe-hauns - I couldn't figure out what you meant, maybe you remember?
  4. Replaces a few Lib::System functions that are now trivial in C++17.

I've asked anyone whose code I've touched to review. But anyone is welcome to review!

Copy link
Contributor

@joe-hauns joe-hauns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me! Great to finally have c++17! Can't wait for structural binding declarations. That will make our iterator chains in the inference rules so much more readable!

Also I fixed the TODO you mentioned.

Debug/TimeProfiling.hpp Outdated Show resolved Hide resolved
@MichaelRawson
Copy link
Contributor Author

Thanks all for quick reviews! Merging.

@MichaelRawson MichaelRawson merged commit 17f44f9 into master Mar 19, 2024
1 check passed
@MichaelRawson MichaelRawson deleted the cpp17 branch March 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants