Minor improvement in instruction limiting, randomization, and strategy sampling #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRawson
requested changes
Feb 29, 2024
… (in particular between parsing and preprocessing) and don't do random stuff until then
…strategy, not knowing what will come out of it
… precise numbers on successful termination) - the commit also advances z3 to the one officially adopted by master now
quickbeam123
force-pushed
the
martin-measurement-and-sampling
branch
from
9fd7d1c
to
7a9360a
Compare
MichaelRawson
approved these changes
Feb 29, 2024
|
Approved, will merge once CI completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timer::updateInstructionCount();in Statistics (to report a more realistic value on successful termination; otherwise it would be the one from the last timer tick)Options.cppfor using_simulatedInstructionLimit(it's actually useful to have it turned on during strategy sampling where we don't know up front if we will end up with lrs or not)atotfis compatible withsilnowtermIduntil a seed is set to non-default, e.g., not until after parsing