prevent loops with anc caused by AVATAR models flip-flopping #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @quickbeam123, we can get into a situation with Minisat (Z3 may have the same problem, I'm not sure) where the solver flip-flops between one of two feasible models. This is not a problem per se - although annoying from a performance point of view - but it does lead to a looping scenario where we:
-anc
, partially-on by default)This quick fix prevents exactly this scenario by not adding duplicate clauses to the SAT solver. A longer-term solution would try to fix the underlying flip-flopping.