Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage #518

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Add coverage #518

merged 5 commits into from
Feb 2, 2024

Conversation

inpefess
Copy link
Contributor

@inpefess inpefess commented Jan 2, 2024

Closes #516
Breaks unit-tests support for Cygwin.
Coverage data collection takes time, but if one can run the tests in parallel, it takes under one minute (tInterpretedFunctions.cpp is the longest-running).

Copy link
Contributor

@MichaelRawson MichaelRawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally happy, thanks for the fiddly work reviving coverage!

@joe-hauns @RobCoutel - I believe you are the main unit testers. Is this useful for you, and do you mind the increased timeout? If it's a problem we could think about how to make the tests run faster or putting coverage behind a flag.

CMakeLists.txt Outdated Show resolved Hide resolved
@joe-hauns
Copy link
Contributor

I didn't ever use any code coverage analysis for c++ but I think any additional linters are great to have so I'm very happy about adding this (without having it tried out yet)!

@inpefess
Copy link
Contributor Author

It seems that master doesn't build with tests enabled now on Cygwin anyway: #519

My branch builds on Cygwin (not in Debug mode) to no surprise since I've changed _exit only in unit-test related code.

For gcc/clang (@MichaelRawson asked earlier) --- they both have --coverage flag, I'm testing locally wih gcc, and CI seems to use clang.

@MichaelRawson MichaelRawson merged commit 9fc43f7 into vprover:master Feb 2, 2024
1 check passed
@inpefess inpefess deleted the add-coverage branch May 8, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revive gcov
3 participants