Modernize rspec syntax #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
modernize-rspec
branch
from
9251196
to
b1c57f8
Compare
bastelfreak
reviewed
Jan 12, 2022
| @@ -21,40 +23,37 @@ | |||
| apply_manifest(pp, catch_failures: true) | |||
| end | |||
|
|
|||
| describe command("/usr/bin/curl https://#{fact('hostname')}.example.com:443") do | |||
| its(:exit_status) { is_expected.to eq 60 } | |||
| specify do | |||
There was a problem hiding this comment.
nice, never saw that before
There was a problem hiding this comment.
This is applying lessons from rubocop/rubocop-rspec#1231. I had seen it, but not used it before.
bastelfreak
approved these changes
Jan 12, 2022
ekohl
force-pushed
the
modernize-rspec
branch
from
b1c57f8
to
8b41f24
Compare
bastelfreak
approved these changes
Jan 12, 2022
ekohl
force-pushed
the
modernize-rspec
branch
from
8b41f24
to
ef49fd3
Compare
bastelfreak
approved these changes
Jan 13, 2022
This takes lessons from the rubocop-rspec issue[1] and applies them to write a more modern style. This should be more compatible with future versions of rspec. [1]: rubocop/rubocop-rspec#1231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes lessons from the rubocop-rspec issue and applies them to write a more modern style. This should be more compatible with future versions of rspec.