Add plugin_type for hiera configuration #139
Conversation
Added processors and aggregators
| @@ -119,6 +125,8 @@ | |||
| Boolean $quiet = $telegraf::params::quiet, | |||
| Hash $inputs = $telegraf::params::inputs, | |||
| Hash $outputs = $telegraf::params::outputs, | |||
| Hash $processors = $telegraf::params::processors, | |||
There was a problem hiding this comment.
since those defaults are identical across every operating system, we don't need to define it within hiera:
| Hash $processors = $telegraf::params::processors, | |
| Hash $processors = {}, |
Are you able to enforce the datatypes within the hash?
There was a problem hiding this comment.
The current params.pp does not contain the parameters aggregators or processors.
| @@ -119,6 +125,8 @@ | |||
| Boolean $quiet = $telegraf::params::quiet, | |||
| Hash $inputs = $telegraf::params::inputs, | |||
| Hash $outputs = $telegraf::params::outputs, | |||
| Hash $processors = $telegraf::params::processors, | |||
| Hash $aggregators = $telegraf::params::aggregators, | |||
There was a problem hiding this comment.
| Hash $aggregators = $telegraf::params::aggregators, | |
| Hash $aggregators = {}, |
|
|
||
| @outputs.sort.each do |key, values| |
There was a problem hiding this comment.
quite a lot of changes here. are you able to add some tests to verify the filecontent? We do something similar in the prometheus module:
There was a problem hiding this comment.
This is awesome. The current code only allows to configure outputs, inputs, processors and aggregators.
This pull request also allows to disable them.
@hanej It would be great if you could add the missing unit tests.
bastelfreak
changed the title
bastelfreak
added
enhancement
|
Dear @hanej, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Pull Request (PR) description
This was supposed to be originally part of pull request #80 but it looks like I missed adding it in. This allows you to use hiera with plugin_type to manage your telegraf.conf.