Add a socket_service definition #197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd::socket_service is a typethat may have no external impact to Forge modules. This module is declared in 8 of 576 indexed public
|
bastelfreak
approved these changes
May 26, 2021
|
In theforeman/puppet-pulpcore#199 I'm testing if the approach works. A draft until then. |
ekohl
force-pushed
the
socket-service-definition
branch
2 times, most recently
from
0805b45
to
5606850
Compare
bastelfreak
approved these changes
May 31, 2021
ekohl
force-pushed
the
socket-service-definition
branch
from
5606850
to
a8b6d49
Compare
bastelfreak
approved these changes
May 31, 2021
|
This now fails on https://tickets.puppetlabs.com/browse/MODULES-11018. I'll add a workaround. |
ekohl
force-pushed
the
socket-service-definition
branch
2 times, most recently
from
887c186
to
e8efe7e
Compare
For systemd socket activated services it's needed to have both the .socket and .service unit defintions in place when starting the service. Prior to 97dd16f the systemctl daemon-reload took care of it, but now this must be done explicitly. This new defined type makes it easy and reduces the burden on modules that define the unit/service pair.
ekohl
force-pushed
the
socket-service-definition
branch
from
e8efe7e
to
29473c6
Compare
|
I've rebased this, but too tired to fix the dependency cycles now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For systemd socket activated services it's needed to have both the .socket and .service unit defintions in place when starting the service. Prior to 97dd16f the systemctl daemon-reload took care of it, but now this must be done explicitly.
This new defined type makes it easy and reduces the burden on modules that define the unit/service pair.
I haven't tested this yet, but submitting it early so I can run CI on it and link it elsewhere.