Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update File tree in Readme #259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MartyEwings
Copy link

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

The root url is described  as `puppet:///modules/splunk` This means the illustration of the directory structure for the `products` path starts in the root of the module, which has caused confusion to some users
@MartyEwings
Copy link
Author

The root url is described as puppet:///modules/splunk This means the illustration of the directory structure for the products path starts in the root of the module, which has caused confusion to some users

@alexjfisher alexjfisher added the docs Improvements or additions to documentation label Sep 30, 2019
@alexjfisher
Copy link
Member

Perhaps the docs could be clearer, but I'm not sure this specific change is helping much. By default, the root is actually https://download.splunk.com and not puppet:///modules/splunk. Users might actually want to mirror parts of download.splunk.com on their own webserver and not in a puppet module.
Line 68 does mention files in the path.

Any change would also be needed in params.pp too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation tests-fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants