WIP: Add upgrade/version handling for splunkforwarder #164
Conversation
|
Hi @arjenz, thanks for the PR. Can you take a look at the failing travis jobs? |
|
@bastelfreak It will only ensure a version on RedHat now, and rebased with latest master. The 'apt' provider is versionable, but 'dpkg' is not (which is being used here). apt also can install dpkg files directly on more recent versions, but not sure if that's exposed through puppet. |
arjenz
force-pushed
the
upgrade
branch
4 times, most recently
from
a764ccf
to
143d97a
Compare
|
Just as a note, we've noticed the exec virtual resource won't be realized on an upgrade, as the file (/opt/splunkforwarder/etc/auth/server.pem) continues to exist between upgrades. Since this modification isn't removing that file as well, then this would never allow the exec to fire. |
- Change "ensure" to an explicit version (otherwise only the file in /opt/staging will be added when $version is bumped) - Extra handling of accepting the license - Limit `ensure => version` to RedHat, the 'dpkg' provider is not versionable, so only specify version on osfamily RedHat.
|
Dear @arjenz, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @arjenz, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @arjenz, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @arjenz, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
This allows upgrading splunkforwarder by bumping version/build passed to this module. As a workaround more or less for #125.
Changing the version/build parameters to
splunk::paramsresults in:Only implemented for splunkforwarder and tested on CentOS right now. If there's interest I can expand it to support splunk and test on other distributions.
ensure => absentfor the ftr file might even completely replaceExec['license_splunkforwarder']eventually (untested, however)