Improve syslinux::system class #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikerenfro
changed the title
smortex
reviewed
Mar 21, 2023
manifests/syslinux/system.pp
Outdated
Comment on lines
21
to
24
| file { "${tftp_root}/syslinux/${file}": | ||
| source => "${syslinux_dir}/${file}", | ||
| require => Package['syslinux'], | ||
| } |
There was a problem hiding this comment.
Maybe we can manage the directory itself. If source is a directory and recurse is set to true, it should copy all files and not need an update if the files change at some point.
Suggested change
| file { "${tftp_root}/syslinux/${file}": | |
| source => "${syslinux_dir}/${file}", | |
| require => Package['syslinux'], | |
| } | |
| file { "${tftp_root}/syslinux": | |
| source => $syslinux_dir, | |
| recurse => true, | |
| require => Package['syslinux'], | |
| } |
There was a problem hiding this comment.
Made the changes I thought would work, but I'm getting CI errors on BSD. An extra set of eyes would be appreciated.
Co-authored-by: Romain Tartière <romain@blogreen.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Improve syslinux::system class
This Pull Request (PR) fixes the following issues
No issues submitted so far, but it looked like most of the development focus was on deploying syslinux from upstream sources rather than OS packages. Out of the box, the module didn't include all the files needed to present a working PXE menu.