Add graph_facts variable to enable graphing (pie/bar) of Puppet facts #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
requested changes
Dec 29, 2022
REFERENCE.md
Outdated
|
|
||
| Data type: `Optional[Variant[String[1], Array[String[1]]]]` | ||
|
|
||
| A list of the puppet facts to graph. See ''https://github.com/voxpupuli/puppetboard'' |
There was a problem hiding this comment.
This file needs to be regenerated since it doesn't match the documentation comment.
There was a problem hiding this comment.
Pardon my ignorance but I don't know what you mean by "needs to be regenerated." How does one regenerate this file?
bschonec
force-pushed
the
add_graph_facts_option
branch
from
b8bfc09
to
6a4c27b
Compare
bastelfreak
reviewed
Jan 7, 2023
| @@ -63,6 +63,9 @@ DEFAULT_ENVIRONMENT = '<%= @default_environment %>' | |||
| <% if @reports_count -%> | |||
| REPORTS_COUNT = <%= @reports_count %> | |||
| <% end -%> | |||
| <% if @graph_facts -%> | |||
| GRAPH_FACTS = '<%= @graph_facts.sort.uniq.join(',') %>' | |||
There was a problem hiding this comment.
please add a unit test for the change with a string as input and one with an array. We need to ensure the sort.uniq.join construct works with strings as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The extra_settings is somewhat cumbersome to use for GRAPH_FACTS in the settings.py file because it necessitates escaping the single quote character around the facts to be graphed. This PR adds the graph_facts variable as an array, sorts and unique-ifies the array and wraps the result in a set of single quotes:
GRAPH_FACTS = 'kernel,operatingsystem,operatingsystemmajrelease'