Fix arch acceptance test #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
force-pushed
the
fix_arch_acceptance_test
branch
4 times, most recently
from
3e46104
to
0cac5c7
Compare
TheMeier
force-pushed
the
fix_arch_acceptance_test
branch
from
0cac5c7
to
4e5c6ff
Compare
bastelfreak
reviewed
May 5, 2024
bastelfreak
reviewed
May 5, 2024
TheMeier
force-pushed
the
fix_arch_acceptance_test
branch
3 times, most recently
from
4bcf954
to
8115478
Compare
|
Hallo! Fill out this form if you'd like to claim your May the Source Be With You sticker! https://forms.office.com/r/Cn55uJmWMH |
This was referenced May 11, 2024
bastelfreak
reviewed
May 18, 2024
bastelfreak
reviewed
May 18, 2024
TheMeier
force-pushed
the
fix_arch_acceptance_test
branch
from
8115478
to
aea810b
Compare
This commit fixes the Archlinux tests. Most notably the default for `install_method` is reset to the default for Archlinux. This is because most exporters actually don't have a package for Archlinux. The changes are somwhat backwards incompatible, but I would argue that previously the module was broken for Archlinux. So I consider this a bugfix instead.
TheMeier
force-pushed
the
fix_arch_acceptance_test
branch
from
aea810b
to
8a142e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Archlinux tests. Most notably the default for
install_methodis reset to the default for Archlinux. This is because most exporters actually don't have a package for Archlinux. The changes are somwhat backwards incompatible, but I would argue that previously the module was broken for Archlinux. So I consider this a bugfix instead.