Update default external_labels #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit sets `external_labels` to an empty hash by default. The previous value prevent the use of deep-merge strategy for the key `prometheus::global_config` when using hiera. Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
wilfriedroset
force-pushed
the
default-external-labels
branch
from
c98bdc9
to
8633b66
Compare
|
Thanks for the PR. I would like to keep this open until we've a few breaking changes and can relase all of them in a new major release. |
|
@bastelfreak any chance to get this merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The following commit sets
external_labelsto an empty hash by default. The previous value prevent the use of deep-merge strategy for the keyprometheus::global_configwhen using hiera.This Pull Request (PR) fixes the following issues
None