add timeout_stop to control systemd TimeoutStopSec

[antondollmaier]

Pull Request (PR) description

With larger WAL segments, prometheus fails to write
a new checkpoint in TimeoutStopSec time:

Oct 03 15:13:37 prometheus prometheus[2452]: level=info ts=2020-10-03T15:13:37.751Z caller=checkpoint.go:96 component=tsdb msg="Creating checkpoint" from_segment=85417 to_segment=85677 mint
Oct 03 15:15:06 prometheus systemd[1]: prometheus.service: State 'stop-sigterm' timed out. Killing.
Oct 03 15:15:06 prometheus systemd[1]: prometheus.service: Killing process 2452 (prometheus) with signal SIGKILL.
Oct 03 15:15:06 prometheus systemd[1]: prometheus.service: Main process exited, code=killed, status=9/KILL
Oct 03 15:15:06 prometheus systemd[1]: prometheus.service: Failed with result 'timeout'.
Oct 03 15:15:06 prometheus systemd[1]: Stopped Prometheus Monitoring framework.

This change adds a new parameter to define TimeoutStopSec
for prometheus.service.

This Pull Request (PR) fixes the following issues

No issue previously created.

The required systemd unitfile overwrite could have been made locally as well - but as I suppose that others could also face similar issues, I decided to implement the parameter directly.

[igalic]

🙋🏻‍♀️

[igalic]

i feel like we can do better than this
but that better type would either belong here:
https://github.com/camptocamp/puppet-systemd/tree/master/types

unless a general one already exists here: https://github.com/puppetlabs/puppetlabs-stdlib/tree/main/types

[antondollmaier]

I totally agree that "String" is very ... liberal - and I checked both modules before.

Let's see if there's nice regex to be drafted in a puppet type before merging.

[bastelfreak]

@antondollmaier can you please rebase against our latest master branch?

[bastelfreak]

@antondollmaier ping :)

[vox-pupuli-tasks]

Dear @antondollmaier, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[TheMeier]

I have opened a new issue to change the systemd configuration, which will allow customization like this without adding new parameters. #734
Since this PR has not seen any action for a while I will close it.