WIP: Fix for the #434 dependency cycle #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you see if #434 (comment) or similar helps? |
|
Dear @gdubicki, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Can someone who knows beaker better than me please check why the CI test are failing? I tried rebasing against master in #534 but it did not help. |
gdubicki
force-pushed
the
v10.0.0_workaround_434
branch
from
f180096
to
86d17be
Compare
|
Since puppet 6 is not supported anymore I think this is obsolete. Please re-open the PR if I am wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
Note: this PR is still Work-In-Progress as I have not tested all edge cases but it does work. Perhaps you have the time to take a look on your side and maybe your will either immediately tell me that is totally wrong or the other way around. I will get back to this when I will have more time.