Change the default value for $otelcol::processors::order to 10
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels like this can unexpectedly change the behavior for some users? If so, this should rather be labelled as backwards-incompatible.
Please update REFERENCE.md with $ bundle exec rake strings:generate:referenceAdd it to the PR and CI should continue. |
smortex
changed the title
$otelcol::processors::order to 10
smortex
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
According to the documentation it would make sense to be able to declare processors that are always first.
Therefore I'd suggest to raise the default order value to 10.
One could skip the order parameter in day-to-day operations and would still be able to have them in the right order.
This Pull Request (PR) fixes the following issues