add user/group/mode parameter to custom types #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jul 5, 2021
ekohl
reviewed
Jul 5, 2021
trefzer
force-pushed
the
dev_add_permissions
branch
2 times, most recently
from
a2fe174
to
b4d8368
Compare
ekohl
reviewed
Jul 5, 2021
trefzer
force-pushed
the
dev_add_permissions
branch
from
b4d8368
to
bd05228
Compare
ghoneycutt
requested changes
Aug 25, 2021
ghoneycutt
reviewed
Aug 25, 2021
| newproperty(:mode) do | ||
| desc 'mode of the file' | ||
| validate do |value| | ||
| unless value =~ %r{^0\d\d\d$} |
There was a problem hiding this comment.
Can you test against stdlib's filemode type which has testing instead of this regex which does not really cover valid modes?
There was a problem hiding this comment.
Can you give me any further hints what you mean ? I also have no idea how to use Stlib::Filemode type for this property. As far as I can see, if Stdlib::Filemode is used, we need some more logic to adapt for the setter/getter to work.
There was a problem hiding this comment.
I don't think you can use type aliases in types (yes, that's confusing; naming is hard).
trefzer
force-pushed
the
dev_add_permissions
branch
from
bd05228
to
11346f0
Compare
This partly implements Issue voxpupuli#95 (missing is default)
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
trefzer
force-pushed
the
dev_add_permissions
branch
from
11346f0
to
114d852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to directly specify user/group and mode for key, request, cert and dh.
In a second step the manifests could be simplified (no need for file resources setting permissions).