Add rule for filtering outgoing DNS server traffic #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
I am a bit worried about the way this feels complex, but understand that consistency is sometimes better that simplicity, so maybe this is fine? That's clearly not a no-go for me, so I'll approve this, but maybe users of the module will want to share their mind.
bastelfreak
force-pushed
the
dns
branch
5 times, most recently
from
9b1a193
to
afd3578
Compare
bastelfreak
commented
Dec 19, 2023
| Stdlib::IP::Address::V4 => "ip saddr ${dns}", | ||
| } | ||
| nftables::rule { "default_out-dnsservertcp-${index}": | ||
| content => "${content} tcp sport 53 accept", |
There was a problem hiding this comment.
derp, I need to rethink this. DNS servers don't respond with src port 53 but a random port. Maybe we can just close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues