Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian 12 #197

Merged
merged 4 commits into from Apr 5, 2024
Merged

Add support for Debian 12 #197

merged 4 commits into from Apr 5, 2024

Conversation

cFire
Copy link
Contributor

@cFire cFire commented Jun 23, 2023

Pull Request (PR) description

Created the template for Debian 12 based on the default jail.conf that ships with the fail2ban bookworm package.

This Pull Request (PR) fixes the following issues

n/a

@NITEMAN
Copy link

NITEMAN commented Jul 17, 2023

Test failure seems unrelated, but I guess tests for Debian 12 should be added

@cFire
Copy link
Contributor Author

cFire commented Jul 17, 2023

Are Debian 12 tests something I can add in the PR? Or do they need to be configured elsewhere?

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for Debian 12 bookworm won't work until packages are available: https://tickets.puppetlabs.com/browse/PA-4995

templates/Debian/12/etc/fail2ban/jail.conf.epp Outdated Show resolved Hide resolved
Enucatl added a commit to Enucatl/puppet-control-repo that referenced this pull request Oct 27, 2023
@tskirvin
Copy link

This doesn't work on Debian 12. The default fail2ban::action is still set to action_mb, which doesn't exist for Debian 12 in this template. FYI.

@cFire
Copy link
Contributor Author

cFire commented Dec 14, 2023

This doesn't work on Debian 12. The default fail2ban::action is still set to action_mb, which doesn't exist for Debian 12 in this template. FYI.

Thanks for letting me know. I never noticed it was missing since I set a different action in my config. I've merged the actions section from the Debian 11 config into the current file but I don't have a good way to test the action_mb on my system, so if you have some way to test and verify that would be great!

@tskirvin
Copy link

This doesn't work on Debian 12. The default fail2ban::action is still set to action_mb, which doesn't exist for Debian 12 in this template. FYI.

Thanks for letting me know. I never noticed it was missing since I set a different action in my config. I've merged the actions section from the Debian 11 config into the current file but I don't have a good way to test the action_mb on my system, so if you have some way to test and verify that would be great!

I did a tiny amount of checking, and it works now, but honestly I was convinced to switch back to something besides action_mb anyway because I didn't actually want the emails. Thanks for the encouragement!

@kwisatz
Copy link

kwisatz commented Jan 18, 2024

This seems to have been approved. Will we see a new release with this included anytime soon?

@kenyon kenyon added the enhancement New feature or request label Apr 5, 2024
cFire and others added 4 commits April 5, 2024 08:30
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
The Debian 11 template had some custom actions that are not in the upstream Debian package jail.conf.
Added Debian 12 testcase
@kenyon kenyon merged commit f3ed0c1 into voxpupuli:master Apr 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants