Optional keystore mgmt #1199
Open
Optional keystore mgmt #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Magistro <koncept1@gmail.com>
Signed-off-by: Ben Magistro <koncept1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This change makes managing the secrets keystore optional. Since the code in that is still setup for instance based deployments which are no longer supported it causes failures when utilizing this module. By making the secrets keystore management optional it buys time to fix that code while still allowing users to take advantage of the other managed aspects.
This PR is based off of #1198 as we needed both changes in our environment.
This Pull Request (PR) likely relates to the following issues
#1153
#1108
#983