Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support full customizable repo url #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vicinus
Copy link

@vicinus vicinus commented Jan 5, 2019

If you are interested I can also add documentation and spec tests. We have the problem, that for some of our customers the repo url format is of the following form, which isn't supported by this module:

https://mirror.example.com/elastic-co/packages/6.x/apt-customername

@jarpy
Copy link
Contributor

jarpy commented Jan 21, 2019

Sorry for the slow reply.

This looks like a good plan to me. Not to be a pain, but we would want to see tests and docs before merging to master. There's also a few trivial bits of style that are causing the current checks to fail.

So, if you have to time to finalize this patch, thanks very, much! If you don't, thanks very much... and I'll find some time to finalize and merge it.

Cheers.

@jarpy
Copy link
Contributor

jarpy commented Jan 21, 2019

Oh, and we ask you to sign the Contributor Licence Agreement (see below), too. It protects the open-sorcery of the project.

@vox-pupuli-tasks
Copy link

Dear @vicinus, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @vicinus, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants